test(smtp): add unit tests for SMTP config, env override, and send #19

Closed

Gravity Bot wants to merge 0 commits from feature/239-smtp-tests into release/v0.3.1

pull from: feature/239-smtp-tests

merge into: mike:release/v0.3.1

mike:main

mike:develop

Conversation 0 Commits - Files changed -

Gravity Bot commented 2026-02-17 20:48:21 +00:00

Contributor

Copy link

Summary

Unit tests for the SMTP setup implementation (OP#164).

• Config loading: env var override with table-driven cases (host, port, security, auth, defaults)
• DB fallback: verifies nil pool takes DB path (not env path)
• Message building: validates MIME headers and body format
• Auth selection: plain, login (falls back to plain), cram-md5, none
• Mock SMTP server: real TCP server for send path testing
• Failure modes: unreachable host (all 3 security modes), missing from address
• Handler tests: env-configured blocks update (403), empty email validation, graceful send failure

All tests pass with -race flag.

Closes OP#239

Test Plan

• go test -race ./internal/services/ ./internal/handlers/ passes
• go vet ./... clean

## Summary Unit tests for the SMTP setup implementation (OP#164). - **Config loading**: env var override with table-driven cases (host, port, security, auth, defaults) - **DB fallback**: verifies nil pool takes DB path (not env path) - **Message building**: validates MIME headers and body format - **Auth selection**: plain, login (falls back to plain), cram-md5, none - **Mock SMTP server**: real TCP server for send path testing - **Failure modes**: unreachable host (all 3 security modes), missing from address - **Handler tests**: env-configured blocks update (403), empty email validation, graceful send failure All tests pass with `-race` flag. Closes OP#239 ## Test Plan - [x] `go test -race ./internal/services/ ./internal/handlers/` passes - [x] `go vet ./...` clean

Gravity Bot added 2 commits 2026-02-17 20:48:21 +00:00

feat(smtp): add email/SMTP configuration and sending ... c53233f35d

Add admin SMTP settings page with server config (host, port, security,
auth), credentials, sender info, enable toggle, and test email feature.
Supports env var override (GASHY_SMTP_*) with read-only UI when
env-configured. Implements EmailService with TLS/STARTTLS/plain modes.

Refs OP#164

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test(smtp): add unit tests for SMTP config, env override, and send ... 59b211ab25

Tests cover: env var override logic with table-driven cases, DB fallback
path verification, message building, auth selection, mock SMTP server
send, unreachable host graceful failure, handler env-block (403), and
empty email validation.

Closes OP#239

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Gravity Bot closed this pull request 2026-02-17 21:20:19 +00:00

Some checks failed

Hide all checks

CI / security (pull_request) Successful in 1m44s

Details

CI / test (pull_request) Successful in 1m45s

Details

CI / build (pull_request) Successful in 1m50s

Details

CI / lint (pull_request) Failing after 2m2s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

mike/gashy!19

No description provided.